Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When installing a single Python version, do not display number installed #4939

Closed
wants to merge 1 commit into from
Closed

When installing a single Python version, do not display number installed #4939

wants to merge 1 commit into from

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jul 9, 2024 •
edited
Loading

e.g.,

Searching for Python versions matching: any Python
Installed Python 3.12.3 to: /Users/zb/Library/Application Support/uv/python/cpython-3.12.3-macos-aarch64-none
Installed Python in 1.80s

instead of Installed 1 version in 1.80s

@zanieb zanieb added cli Related to the command line interface preview Experimental behavior labels Jul 9, 2024
@T-256
Copy link
Contributor

T-256 commented Jul 9, 2024 

 Searching for Python versions matching: any Python
-Installed Python 3.12.3 to: /Users/zb/Library/Application Support/uv/python/cpython-3.12.3-macos-aarch64-none
-Installed Python in 1.80s
+Installed `cpython-3.12.3-macos-aarch64-none` in 1.80s

Getting install location is available by uv python dir, so I think it's better to prevent leak username for privacy 🤷‍♂️

@zanieb
Copy link
Member Author

zanieb commented Jul 9, 2024

Could be nice to use the key there. Hm.

Idk about the install paths, we might need to consider that more holistically as part of #4896 as we do this all over the place right now.

@T-256
Copy link
Contributor

T-256 commented Jul 9, 2024 

Installed 1 python version in 25ms
 + cpython-3.12.3-macos-aarch64-none

Also, I think it's worth to match it to output design of uv pip install which is more stabled.

@charliermarsh charliermarsh self-requested a review July 18, 2024 18:52
@charliermarsh charliermarsh self-assigned this Jul 18, 2024
@charliermarsh
Copy link
Member

Will take over.

@zanieb zanieb closed this Jul 18, 2024
@charliermarsh charliermarsh mentioned this pull request Jul 19, 2024
Merged
charliermarsh added a commit that referenced this pull request Jul 19, 2024
@charliermarsh
Use +- install output for Python versions (#5201)
d54ae4e 
## Summary

Follow-up to #4939. Uses a format
that's closer to `uv pip install`, with some special-casing for single
Pythons.

## Test Plan

A few examples:

![Screenshot 2024-07-18 at 8 39
35 PM](https://github.com/user-attachments/assets/868d4c87-d8f4-4e5f-a52c-1f7a3e8d6a16)
![Screenshot 2024-07-18 at 8 39
46 PM](https://github.com/user-attachments/assets/3a12461e-9d9b-4c33-a685-55ca7256ff52)
![Screenshot 2024-07-18 at 8 39
27 PM](https://github.com/user-attachments/assets/1059e6d6-a445-4531-8496-59bc51d01663)
![Screenshot 2024-07-18 at 8 39
54 PM](https://github.com/user-attachments/assets/dcb69e86-8702-402b-a0cd-6f827b04a6ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees

@charliermarsh charliermarsh

Labels
cli Related to the command line interface preview Experimental behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanieb @T-256 @charliermarsh